management: confirm server-side filtering 404s #18265
Open
+101
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @yaauie? 🙏
|
CHANGED BEHAVIOR (system indices): - when communicating with Elasticsearch >= 7.10, a fetch-all-pipelines query that results in a 404 error is treated as a meaningful error since Elasticsearch does NOT emit 404 when no pipelines have been configured, preventing a misconfigured proxy from causing pipelines to be shut down - when communicating with Elasticsearch >= 8.3, a server-side query for pipelines that results in a 404 error response no longer results in the immediate shut-down of existing pipelines unless a second client-side filtering of all available pipelines indicates that none should be running. MAINTAINED BEHAVIOUR (legacy hidden indices): - when commmunicating with Elasticsearch < 7.10, a pipeline-fetching query that results in a 404 error response is STILL treated as an empty result set, and will cause any running pipelines to be shut down.
yaauie
force-pushed
the
central-management-confirm-the-404
branch
from
af0a331 to
252d4e0
Compare
Collaborator
💛 Build succeeded, but was flaky
Failed CI Steps
History
|
kaisecheng
approved these changes
Nov 11, 2025
Contributor
kaisecheng
left a comment
kaisecheng
left a comment
There was a problem hiding this comment.
LGTM. Confirmed the API returns the corresponding codes as described.
I left a minor suggestion.
| # search to rule out a proxy emitting a 404. | ||
| if es_supports_pipeline_wildcard_search?(es_version) | ||
| begin | ||
| logger.trace("querying for pipelines #{pipeline_ids.join(",")} using server-side wildcard search") |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.trace("querying for pipelines #{pipeline_ids.join(",")} using server-side wildcard search") | |
| logger.trace? && logger.trace("querying for pipelines #{pipeline_ids.join(",")} using server-side wildcard search") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
When Central Management is looking up the instance's assigned pipelines, it now confirms a 404 is in fact an empty assignment, differentiating it from a 404 emitted for other reasons.
Why is it important/What is the impact to the user?
An ES node leaving the cluster can emit a 404, indicating that it cannot satisfy the request, which is different than an indication that the list of pipelines is empty.
This fix prevents such a 404 from shutting down the running pipelines.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
Related issues